fix(ConfigReader): Use CLI options with default config file #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ConfigReader behavior to always use stryker.conf.js if present. CLI options override options from the file. Run does not fail anymore if a CLI option, but no config file is specified. closes stryker-mutator#390
nicojs
requested changes
Oct 2, 2017
packages/stryker/src/ConfigReader.ts
Outdated
|
|
||
| if (!this.cliOptions.configFile) { | ||
| try { | ||
| fs.accessSync(`${process.cwd()}/${DEFAULT_CONFIG_FILE}`); |
There was a problem hiding this comment.
I think it's cleaner to use path.resolve(`./${DEFAULT_CONFIG_FILE}`) here.
packages/stryker/src/ConfigReader.ts
Outdated
| log.info(`Using ${DEFAULT_CONFIG_FILE} in the current working directory.`); | ||
| this.cliOptions.configFile = DEFAULT_CONFIG_FILE; | ||
| } catch (e) { | ||
| log.info('No config file specified. Running with command line arguments.'); |
There was a problem hiding this comment.
Could we also add a message: 'Use `stryker init` command to generate your config file' here? So we help the end user even more?
|
Awesome! You got #404 🥇 |
Display 'Use `stryker init` command to generate your config file.' when stryker is run without a config file.
|
Thanks @Be-ngt-oH . Awesome job 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ConfigReader behavior to always use stryker.conf.js if present. CLI
options override options from the file.
Run does not fail anymore if a CLI option, but no config file is specified.
closes #390